siralam / BSImagePicker

An image picker that extends BottomSheetDialogFragment. Camera and gallery all in one dialog. Single or Multi Selection.
201 stars 62 forks source link

Handling an exception when user does not have any images in the device #9

Closed wrbl606 closed 5 years ago

wrbl606 commented 6 years ago

For now, in case mentioned in the title, screens goes dark (fragment dialog launches) but it has nothing to show. How about displaying some kind of message in the picker in that case? Or displaing a Toast?

I know this issue occurs very rarely but still it is worth investigating.

siralam commented 6 years ago

@wrbl606 May I confirm if this happens only when in multi-selection mode (So that no camera tile or gallery tile is shown)?

Anyway this is a good suggestion, I will consider adding it in the future. Thanks!

wrbl606 commented 6 years ago

It can occur in multiselection mode and in singleselection when both options

.hideCameraTile()
.hideGalleryTile()

are used in it's builder.

siralam commented 6 years ago

@wrbl606 Ah, right. Thank you!

siralam commented 5 years ago

Implemented in 1.1.0