search

siramix / buzzwords

A mobile word game that will change the word.
www.siramix.com/buzzwords
GNU General Public License v3.0
10 stars 1 forks source link

Need a way to disable sound effects #36

Closed cpatrick closed 11 years ago

cpatrick commented 12 years ago

FAOTD Request.

edwardrowe commented 12 years ago

We'd like to add this as a setting to disable the sound effects but leave the music. Buttons won't click, back shouldn't beep, and RWS shouldn't make noise. No Sound Effects, just music. We COULD let them set this from the menu during a turn.

edwardrowe commented 12 years ago

I've added a setting to disable sound effects.

I debated about an implementation for this that would use volume sliders for each, but decided this would confuse the whole thing where you turn off music and get ticking during Turn. We've made sure the two are in balance with each other by default, so I imagine it's a very small subset of people who would want to change the normalization.

edwardrowe commented 12 years ago

Now there's a new question - we obviously don't want to let system click sounds play on button clicks in addition to our custom sounds, but what if they disable sound effects? Would we still want to disable system clicks?

Edit I think there's no way to do the above anyway. We should just disable system sounds across the entire application.

edwardrowe commented 12 years ago

Added application wide disable of sound effects in the BuzzwordsTheme. Also had to disable them manually in PackPurchaseRowLayout, since it doesn't inherit the theme's setting for some reason. Really I should have looked it up on the theme, but I spent too long trying to figure out how. Time to move on.

edwardrowe commented 12 years ago

Was thinking we may want to go with sliders on this to let people balance their music and FX. The real trick here is that if they slide the Music slider all the way down we need to play the "ticking" but we need it to use the Sound FX volume setting.