Fix Lint Warnings like "Hardcoded String" - Githubissues

siramix / buzzwords

A mobile word game that will change the word.

www.siramix.com/buzzwords

GNU General Public License v3.0

10 stars 1 forks source link

Fix Lint Warnings like "Hardcoded String" #57

Closed lucasrowe closed 11 years ago

lucasrowe commented 12 years ago

Here's an example. To turn on Linting go to Preferences - Android - Lint Error Checking.

The one below is for internationalization, so it's not a true problem for us right now. That said, this will teach us some best practices so we should go through all the warnings (there are 225 of them!!!)

Description Resource Path Location Type [I18N] Hardcoded string "Rematch", should use @string resource gameend.xml /phrasecraze/res/layout line 46 Android Lint Problem

edwardrowe commented 12 years ago

Fixed most Lint warnings in all xml layouts. Still have to hit Lint warnings in java files and the manifest. Did a lot of cleanup on strings as well.

edwardrowe commented 12 years ago

Oh I also think we can turn off the content description warning unless we get serious about providing accessibility to this thing.

edwardrowe commented 12 years ago

Removed all the hard coded strings in Rules.xml. Ready for translation!! (Not really)

edwardrowe commented 12 years ago

Removed warnings for unhandled cases, unused members, and unused includes.

edwardrowe commented 12 years ago

Ripped through 100 of these. 60 more to go.

edwardrowe commented 11 years ago

24 warnings remain, all of which I either opened other tasks or don't need to fix:

Not targeting latest version - tasked
Missing drawables for xml files - this is pretty much a faulty error, as these are selectors between pngs which DO appear in both hdpi and mdpi
Should use sp instead of dp (6 issues) - these instances would cause the words to be illegible due to clipping
Missing density variation (xhdpi) - this would be necessary if we were taking Kindle Fire seriously. We can consider this if we want to polish the app for tablets.
Missing content description (13 issues) - all of these assets are trim pieces. I'm not sure we are supposed to give these descriptions or not, but I say we tackle this if we do an accessibility patch.
Linear Layout unnecessary for splash screen. - I don't really think we can get rid of this if we want to keep the background as it is.
rules.xml has more than 80 views. Bad for performance. - I'd like to fix this, but it's going to be a nightmare. I'm not seeing performance PROBLEMS so I want to leave it.