search

siramix / buzzwords

A mobile word game that will change the word.
www.siramix.com/buzzwords
GNU General Public License v3.0
10 stars 1 forks source link

Review all debug and info logging #61

Closed lucasrowe closed 11 years ago

lucasrowe commented 12 years ago

"Verbose should never be compiled into an application except during development. Debug logs are compiled in but stripped at runtime. Error, warning and info logs are always kept."

Consider revising the way we log to be more intelligent and less verbose (even if it strips, there's no point in doing all that). But Patrick you'll know best practice on this one. http://developer.android.com/reference/android/util/Log.html

edwardrowe commented 11 years ago

I'm pretty sure the way we are doing it is OK by wrapping them with the BuzzwordsApplication.DEBUG flag. And if they are log.d()'s we don't need to be SUPER paranoid. I did a search for log.v and found them in PackPurchasing only. Next time we are together Luke we can do a sweep and eliminate them - there are some that just shouldn't be there at all.

lucasrowe commented 11 years ago

Commit 5b2675ef5fb540a6eb4812a0d3bab6cca4157828 should have this figured out.