search

siramix / buzzwords

A mobile word game that will change the word.
www.siramix.com/buzzwords
GNU General Public License v3.0
10 stars 1 forks source link

Bug: Music Doesn't Turn off when Pausing from Certain Activities #81

Closed edwardrowe closed 11 years ago

edwardrowe commented 12 years ago

Some Activities don't do the music continue stuff.

We should consider creating the MusicActivity class Patrick talked about, and converting Title, Rules, GameSetup, PackPurchase to use it.

Either way, we need to make sure these activities stop music on pause before we ship.

edwardrowe commented 12 years ago

I did this the quick and dirty way after encountering a problem with the MusicActivity.

The issue is if we make a class deriving from Activity, called MusicActivity, we run into issues using this class on the Settings screen, which does not directly derive from Activity but from a child of Activity (sibling of MusicActivity), PreferenceActivity.

So I just added the private boolean and OnResume / OnPause handling to PackPurchase, just like it exists in Title, Settings, and GameSetup.

edwardrowe commented 12 years ago

Also has to add these checks to PackInfo activity