Full stack project review

[outisa]

Hi @sirbh !

I reviewed your full stack project and you do not have to do any changes to get the attainment for the course. You can take advantage of my comments either on this or following projects if you like.

Application

Creating a user, logging in and adding a new station works fine without any problems with correct information. If I tried to add an address with just one letter I got error message 'password must be more than 7 chars'. That might be just copy-paste error from somewhere and perhaps an easy fix.

It would be nice that Station list could be sorted at least by Capacity and Station name. Is the City marked wrongly in the datasets? All cities are marked as Espoo even though may of the stations are in Helsinki and perhaps even in Vantaa. Also, only city option is Espoo when adding a new station.

Sorting the journeys with any used options is working well. Search option is also working without any problems in all views. The application is easy to use.

Code

• The structure of the code and naming things is good.
• I would put videos created by cypress to .gitignore
• To further decrease the docker image size in production, I would run command for removing the cypress folder in Dockerfile. Putting it just into the .dockerignore file does not resolve the issue as it is used for both test and production Docker images.
• You have tested your application comprehensively and you have done utilized Docker and CI/CD pipeline in your solution, which is very nice.
• Types are well utilized.
• Is good to check that empty folders/files are cleaned away from the repository.
• It might be a good thing to separate services logic based on the user, journeys and stations. At the moment file is relatively short and everything can be found easily, however, if the project size would increase, this might not be the case anymore.
• I did not see any unused code or debug console.logs in the (production) code, which is really nice.

Overall well done!

[sirbh]

Thanks, @outisa for providing the detailed feedback. I totally agree with your suggested changes.

• I have restructured the services
• Fixed the validation bug on the address field.
• Added remove cypress folder in docker file.

I have frozen the city field to Espoo because in the dataset city was Espoo for some stations and for others, it was not provided so I inferred all the stations are located in Espoo.

In future improvements, I will try to integrate google places API to accurately validate the address details. And instead of showing the stations list, I will show the map of the entire city with all the stations marked. Hence adding tabs to filter the station might not be required.

Can I also send an email to student services to receive the credits for this project?