Closed anomiex closed 3 years ago
Thank you for the detailed investigation! I'm just getting around to preparing various things for PHP 8. I can easily get rid of phpunit-detailed-printer
(here and in my other projects) to simplify things.
I'm wondering what the appropriate thing to do is for phpcs-changed, though because phpcs itself doesn't seem ready to support it, as discussed in this issue: https://github.com/squizlabs/PHP_CodeSniffer/issues/3182 I suppose I could update this code as you suggest since technically there is not reason it shouldn't work if phpcs does. Giving it a shot...
It looks like your PHPUnit tests all pass once dependencies are updated. You'll have some new PHPStan warnings to fix though.
Assuming you don't want to drop support for PHP 7.1, you'll need the following:
"^6.4 || ^9.5"
would work."^3.1 || ^6.0"
will install 6.0 along with PHPUnit 6.4 because LimeDeck doesn't declare its own PHPUnit dependency properly."^6.5 || ^9.0"
.I haven't checked whether you have any code not covered by your tests.