Add git workflow - Githubissues

sirbrillig / phpcs-changed

🐘 Run phpcs on files and only report new warnings/errors compared to the previous version.

MIT License

31 stars 11 forks source link

Add git workflow #4

Closed sirbrillig closed 5 years ago

sirbrillig commented 5 years ago

This adds a --git CLI shortcut and a git workflow to automatically collect the three necessary pieces of data for a git-versioned file in the same way that the --svn shortcut does for svn-versioned files.

[x] Add tests
[x] Add workflow
[x] Add CLI command
[x] Add docs
[x] Handle untracked and unchanged files

Fixes #3

sirbrillig commented 5 years ago

This needs to more gracefully handle untracked (by git) files and files with no changes. Those should both have test cases.

sirbrillig commented 5 years ago

There's two skipped tests that are just not working for some reason. I'd like to get them to run. It's something to do with exception handling. I think the actual CLI works correctly.

sirbrillig commented 5 years ago

🤔 now untracked git files are not being reported at all without --debug. That's no good.

sirbrillig commented 5 years ago

Now I'd like to add svn workflow tests to match the git ones.

sirbrillig commented 5 years ago

Ok, I think this is in good shape. I'd like to clean up the commit history and do a little more real-world testing before merging.