search

sirbrillig / phpcs-changed

🐘 Run phpcs on files and only report new warnings/errors compared to the previous version.
MIT License
31 stars 11 forks source link

Always return 0 from reportMessagesAndExit when run with --arc-lint flag #52

Closed david-binda closed 2 years ago

david-binda commented 2 years ago

When using futures in arcanist linter, the external lint program, eg.: phpcs-changed in this case, should always return 0 status, even if there are lint errors, otherwise the external program's run is considered being unsuccessful.

david-binda commented 2 years ago

Yup, makes sense. The less magic the better :) I have introduced a new --always-exit-zero flag in follow-up commit.

sirbrillig commented 2 years ago

Looks great! Thanks!