sirbrillig / phpcs-changed

🐘 Run phpcs on files and only report new warnings/errors compared to the previous version.
MIT License
31 stars 11 forks source link

Error using PHP 8.2 #64

Closed pbking closed 1 year ago

pbking commented 1 year ago

Using this library with PHP 8.2 caused the following errors to occur:

PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /Projects/themes/vendor/sirbrillig/phpcs-changed/PhpcsChanged/SvnWorkflow.php on line 21
...

(as well as quite a few additional lines)

Changing my version of PHP to 8.0 eliminated those errors.

sirbrillig commented 1 year ago

Thanks. I'll check this out. The specific error you mentioned should have been fixed by https://github.com/sirbrillig/phpcs-changed/pull/63 but I see that I neglected to actually cut a release since then. I'll take care of that.

sirbrillig commented 1 year ago

I've released 2.10.1. Manual testing with PHP 8.2 does not produce any more errors to appear for me. Could you confirm that, @pbking?

sirbrillig commented 1 year ago

I'm going to mark this as resolved unless I get any further information.