This removes the executeCommand and validateExecutableExists functions from ShellOperator, instead making them implementation details of the shell. This will allow for more diverse shells since these functions both assumed a UNIX-like environment.
In their place, this PR adds two new functions to ShellOperator: getPhpcsVersion which is needed by the XmlReporter, and validateShellIsReady which can be used as a general function to perform any necessary validation.
This removes the
executeCommandandvalidateExecutableExistsfunctions fromShellOperator, instead making them implementation details of the shell. This will allow for more diverse shells since these functions both assumed a UNIX-like environment.In their place, this PR adds two new functions to
ShellOperator:getPhpcsVersionwhich is needed by theXmlReporter, andvalidateShellIsReadywhich can be used as a general function to perform any necessary validation.This is part of https://github.com/sirbrillig/phpcs-changed/issues/73