search

sirbrillig / phpcs-changed

🐘 Run phpcs on files and only report new warnings/errors compared to the previous version.
MIT License
31 stars 11 forks source link

Add '--extensions' option to use in PHPCS and for allowed extensions #86

Closed LetrixZ closed 1 year ago

LetrixZ commented 1 year ago

This PR adds the --extensions option to pass to PHPCS command and to use if for allowed extensions when a dir is used instead of a file.

sirbrillig commented 1 year ago

This looks very cool. Thank you for the effort! There's a few failing tests, but I think they just need the new argument provided (try composer precommit to run everything). Could you also add this option to the README?

LetrixZ commented 1 year ago

Done. Passed CliOptions instead of the single option to avoid type issues.

juanmitriatti commented 1 year ago

Hi @sirbrillig This PR is really necessary and useful, will you merge it with the current beta release?. Thanks

sirbrillig commented 1 year ago

That is my plan, yes. I just have had a busy weekend.

sirbrillig commented 1 year ago

This looks great! Thank you!