search

sircharlo / meeting-media-manager

A cross platform app to download and present media (pictures and videos) for congregation meetings of Jehovah’s Witnesses in any language. Features include recurring and custom media management, congregation sync, and media presentation tools for hybrid, in-person or fully remote Zoom meetings.
GNU Affero General Public License v3.0
131 stars 23 forks source link

[BUG] Pure Worship intro image for chapter not included #148

Closed mtdvlpr closed 2 years ago

mtdvlpr commented 2 years ago

Describe the bug The Pure Worship (rr) images at the top of every chapter are not included when that week we start on a new chapter. The introductory video is included, but I also expect the image to be included.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Home'
  2. Click on 'Get Media!'
  3. Open target folder
  4. See that chapter image is missing

Expected behavior The image at the top of the chapter should be included when starting a new chapter and when the paragraph referencing the image is discussed that week (maybe that's not doable, in that case always include the chapter image).

System specs (please complete the following information):

Additional context Related to #140

sircharlo commented 2 years ago

Hello again! 😄 Thanks for pointing out these bugs. I had also noticed this one, and it was consequently fixed with https://github.com/sircharlo/jw-meeting-media-fetcher/commit/db5e17e141042f91379bc8badf118606b7b82c2d. Similarly to issue #147 that you pointed out, I'll release this fix sometime soon, ideally before the next chapter of rr begins, that is on the week of December 27th. I consider that the ship has however already sailed for this week..! Let me know if you have any thoughts. - COS

mtdvlpr commented 2 years ago

No problem! Thank you for all the effort you put and continue putting into this. I am a relatively new user, but I like it very much! I am also considering diving into your code one day with the goal to perhaps be able to contribute 😄

sircharlo commented 2 years ago

No problem! Thank you for all the effort you put and continue putting into this. I am a relatively new user, but I like it very much! I am also considering diving into your code one day with the goal to perhaps be able to contribute 😄

It's my great pleasure! It's turned into quite the project, but I very much enjoy it. 😄 I will however take all the help that's offered... 😉