sircharlo / meeting-media-manager

A cross platform app to download and present media for congregation meetings of Jehovah’s Witnesses in any language. Features include automatic media downloading, easy drag-and-drop adding of additional media, and media presentation tools for meetings.
https://sircharlo.github.io/meeting-media-manager/
GNU Affero General Public License v3.0
146 stars 26 forks source link

Circuit Overseer Visit Setting Causes Missing Mid Song and Incorrect Sorting of Media #1839

Closed Tdanforth closed 1 year ago

Tdanforth commented 1 year ago

What happened?

My congregation had the CO visit Tuesday. I used the setting to set the date of the CO visit. When I went into the media controller, I saw that the mid song was missing (song 119). Also, the Are You Prepared for a Disaster? video and it's pictures were in the Apply Yourself To The Field Ministry section instead of the Living as Christians section. I reproduce it on my computer and it did the same as the KH computer.

To Reproduce

  1. Set Next planned visit of circuit overseer to 5-9
  2. Set computer date manually to 5-9
  3. Reopen M3
  4. Update media folder
  5. Go to media controller

What did you expect to happen?

To have midsong and the media sorted correctly (Are You Prepared for a Disaster?)

Version

v23.4.1

What platform are you seeing the problem on?

Windows

Relevant log output

{}

Screenshots

image

Additional context

Windows_NT 10.0.19043 x64

Anonymized prefs.json

{
  "app": {
    "autoOpenFolderWhenDone": false,
    "autoQuitWhenDone": false,
    "autoRunAtBoot": false,
    "autoStartSync": false,
    "betaUpdates": true,
    "congregationName": "West Hills",
    "customCachePath": null,
    "disableAutoUpdate": true,
    "disableHardwareAcceleration": false,
    "localAppLang": "en",
    "localOutputPath": "***",
    "obs": {
      "enable": false,
      "port": "4444",
      "password": "***",
      "mediaScene": "Scene 3",
      "cameraScene": "Space",
      "useV4": true,
      "zoomScene": null,
      "imageScene": null
    },
    "offline": false,
    "outputFolderDateFormat": "YYYY-MM-DD",
    "theme": "dark",
    "zoom": {
      "enable": false,
      "name": "Video",
      "id": "***",
      "password": "***",
      "spotlight": true,
      "hideComponent": true,
      "autoRename": "***",
      "autoStartMeeting": true,
      "autoStartTime": 1
    }
  },
  "cong": {
    "server": null,
    "port": null,
    "user": null,
    "password": null,
    "dir": null,
    "enable": false,
    "username": null
  },
  "media": {
    "autoPlayFirst": false,
    "autoPlayFirstTime": 5,
    "enableMediaDisplayButton": true,
    "enableMp4Conversion": false,
    "enablePp": false,
    "enableSubtitles": false,
    "enableVlcPlaylistCreation": false,
    "excludeLffImages": true,
    "excludeTh": true,
    "hideMediaLogo": false,
    "hideWinAfterMedia": false,
    "includePrinted": false,
    "keepOriginalsAfterConversion": false,
    "lang": "E",
    "langFallback": null,
    "langSubs": null,
    "langUpdatedLast": "2023-03-24T02:39:59.745Z",
    "maxRes": "720p",
    "mediaWinShortcut": "Alt+Z",
    "ppBackward": null,
    "ppForward": null,
    "preferredOutput": "2779098405",
    "presentShortcut": "Alt+D"
  },
  "meeting": {
    "autoStartMusic": false,
    "enableMusicButton": true,
    "enableMusicFadeOut": true,
    "coWeek": "2023-05-09",
    "musicFadeOutTime": 5,
    "musicFadeOutType": "smart",
    "musicVolume": 1,
    "mwDay": 3,
    "mwStartTime": "07:30",
    "shuffleShortcut": "Alt+K",
    "specialCong": false,
    "weDay": 6,
    "weStartTime": "10:00"
  },
  "__internal__": {
    "migrations": {
      "version": "23.4.1"
    }
  }
}
sircharlo commented 1 year ago

Adressed here. It has to do with the fact that the last song, exceptionally, wasn't from the usual sjjm series.

Won't happen in the future, as we'll identify the last song without requiring it to be from sjjm. The fix will be released along with the upcoming refactor.

To be clear, this edge case would only happen if it's the CO visit and the last song is not from sjjm.