sircharlo / meeting-media-manager

A cross platform app to download and present media for congregation meetings of Jehovah’s Witnesses in any language. Features include automatic media downloading, easy drag-and-drop adding of additional media, and media presentation tools for meetings.
https://sircharlo.github.io/meeting-media-manager/
GNU Affero General Public License v3.0
146 stars 26 forks source link

[App][Bug]: Music with comments before meeting #2315

Closed dagandrew closed 10 months ago

dagandrew commented 10 months ago

What happened?

There are files that shouldn't be there. When I tried to manually delete unnecessary files it shows an error when it goes eventually to the file.

To Reproduce

  1. Go to 'Meeting Setup'
  2. Click on 'Enable button to play background music'

What did you expect to happen?

so there no background without comments

Version

v23.12.0

What platform are you seeing the problem on?

Windows

Relevant log output

{}

Screenshots

No response

Additional context

Windows_NT 10.0.22000 x64

Anonymized prefs.json

{
  "app": {
    "autoOpenFolderWhenDone": false,
    "autoQuitWhenDone": false,
    "autoRunAtBoot": false,
    "autoStartSync": false,
    "betaUpdates": false,
    "congregationName": "East Congregation",
    "customCachePath": "***",
    "disableAutoUpdate": false,
    "disableHardwareAcceleration": false,
    "localAppLang": "en",
    "localOutputPath": "***",
    "obs": {
      "enable": false,
      "port": null,
      "password": null,
      "mediaScene": null,
      "imageScene": null,
      "cameraScene": null,
      "zoomScene": null,
      "useV4": false
    },
    "offline": false,
    "outputFolderDateFormat": "YYYY-MM-DD",
    "theme": "system",
    "zoom": {
      "enable": false,
      "name": "7-4",
      "id": "***",
      "password": "***",
      "spotlight": true,
      "hideComponent": true,
      "autoRename": "***",
      "autoStartMeeting": true,
      "autoStartTime": 1
    }
  },
  "cong": {
    "server": "",
    "port": "***",
    "user": null,
    "password": null,
    "dir": "***"
  },
  "media": {
    "autoPlayFirst": false,
    "autoPlayFirstTime": 5,
    "enableMediaDisplayButton": false,
    "enableMp4Conversion": false,
    "enablePp": false,
    "enableSubtitles": false,
    "enableVlcPlaylistCreation": false,
    "excludeLffImages": true,
    "excludeTh": true,
    "excludeFootnotes": true,
    "hideMediaLogo": false,
    "hideWinAfterMedia": false,
    "includePrinted": false,
    "keepOriginalsAfterConversion": false,
    "lang": "U",
    "langFallback": null,
    "langSubs": null,
    "langUpdatedLast": "2023-12-05T12:03:31.212Z",
    "maxRes": "480p",
    "mediaWinShortcut": "Alt+Z",
    "ppBackward": null,
    "ppForward": null,
    "preferredOutput": "window",
    "presentShortcut": "Alt+D"
  },
  "meeting": {
    "autoStartMusic": true,
    "enableMusicButton": true,
    "enableMusicFadeOut": true,
    "coWeek": null,
    "musicFadeOutTime": 5,
    "musicFadeOutType": "smart",
    "musicVolume": 12,
    "mwDay": 1,
    "mwStartTime": "22:00",
    "shuffleShortcut": "Alt+K",
    "specialCong": false,
    "weDay": 6,
    "weStartTime": "11:00"
  },
  "__internal__": {
    "migrations": {
      "version": "23.12.0"
    }
  }
}
sircharlo commented 10 months ago

I had something similar happen. I believe this is linked to the described audio versions of songs now being available. We'll need to ignore these when downloading songs for background music.

mtdvlpr commented 10 months ago

@sircharlo, you're right. #2316 fixes this. Audio description songs have a track nr in the 500s.

sircharlo commented 10 months ago

Awesome job!! Thanks for the quick fix. Could we release this ASAP? This is a pretty disruptive bug.

mtdvlpr commented 10 months ago

@dagandrew the fix has been released :)

dagandrew commented 10 months ago

@dagandrew the fix has been released :)

thank you so much for quick help! It was very much needed