search

sircharlo / meeting-media-manager

A cross platform app to download and present media (pictures and videos) for congregation meetings of Jehovah’s Witnesses in any language. Features include recurring and custom media management, congregation sync, and media presentation tools for hybrid, in-person or fully remote Zoom meetings.
GNU Affero General Public License v3.0
133 stars 23 forks source link

[Bug]: Can't download media for the week from 2024-08-05 #2521

Closed dagandrew closed 2 months ago

dagandrew commented 2 months ago

What happened?

I can download media every week before and even after, but not this one, it's just loading and nothing happens. Not even an error. I've checked the folders and it created the folder for the weekend meeting, but not for the midweek one. Maybe it's stuck there.

To Reproduce

  1. Select the Week
  2. Click Update Media
  3. See error

What did you expect to happen?

to download the media

Version

v24.4.0

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Screenshots

No response

Additional context

No response

mtdvlpr commented 2 months ago

Hi @dagandrew, thanks for reporting! The issue is that that particular midweek meeting program is making a reference to itself, causing an infinite loop in M3. A release with the fix is underway!

mtdvlpr commented 2 months ago

@sircharlo, this bug might also exist in your refactor. See #2524 for the fix.

BTW: Kudos on the refactor! It's really nice. I'm sorry that I couldn't deliver the other refactor...

mtdvlpr commented 2 months ago

The fix has been released in v24.4.1

sircharlo commented 1 month ago

@sircharlo, this bug might also exist in your refactor. See #2524 for the fix.

Thanks! I haven't actually implemented InternalLink fetching just yet. I'm trying to see cases where it would be needed, but from what I see it would be pretty rare. In any case, I'll be sure to add this logic when implementing it.

BTW: Kudos on the refactor! It's really nice. I'm sorry that I couldn't deliver the other refactor...

@mtdvlpr Please don't apologize! You worked so hard on it! Your ideas are a major part of what kept this project going during the period where I could not do much with it. Thank you so much for all your contributions! I, along with everyone who uses the app, am super grateful ☺️