sircharlo / meeting-media-manager

A cross platform app to download and present media for congregation meetings of Jehovah’s Witnesses in any language. Features include automatic media downloading, easy drag-and-drop adding of additional media, and media presentation tools for meetings.
https://sircharlo.github.io/meeting-media-manager/
GNU Affero General Public License v3.0
150 stars 27 forks source link

[Bug]: 'Add media' menu small adjustments #3448

Open ux-git opened 1 week ago

ux-git commented 1 week ago

What happened?

Not really a bug, but a small design improvements proposal

To Reproduce

Open the menu

What did you expect to happen?

  1. Use an accent color variable for hover state, something like accent-100 or accent-200, depending on what looks on the relatively same contrast level as the current grey hover color.

  2. The S-34 file is downloaded from our website, but it should be imported from the user's device. Meaning that the import doesn't really happen from the website. Shouldn't it be moved to the lower 'From your device' category?

Screenshot 2024-11-21 at 10 09 30

Version

v24.11.5

What platform are you seeing the problem on?

macOS

Relevant log output

No response

Screenshots

No response

Additional context

No response

Confirmations

sircharlo commented 1 week ago
  1. Fixed in 243b92222b3a3dee282d604ed7f3d3ec75fdb4ce.
  2. Good point! Fixed in a64077a5eb25cc85cb72738f6ca87734bb7a3bfe.
mtdvlpr commented 6 days ago

@sircharlo, I think @ux-git meant changing the grey hover color to an accent color and not changing the icon color to grey. @ux-git, correct me if I'm wrong!

The currently committed fix: image

ux-git commented 6 days ago

@mtdvlpr @sircharlo yes, I mean the hover color. Sorry if I was unclear

mtdvlpr commented 6 days ago

This is what I've implemented in fc0c2fa2ef90eb3e6557cf38608a96fc9cd2364f:

Dark mode ![image](https://github.com/user-attachments/assets/2aa3f02a-ee47-4694-be85-98bd451f14fb)
Light mode ![image](https://github.com/user-attachments/assets/73871f2d-ec7f-4a75-8f18-acb40575b907)
sircharlo commented 6 days ago

😬 Sorry I misunderstood!