Checklist before releasing 22.11.0

[mtdvlpr]

Some things that need to be tested again before releasing:

• [x] Malagasy works without dayjs error
• [x] Image zoom and pan works correctly and preview and media window always show the same (https://github.com/sircharlo/meeting-media-manager/commit/3399c9a32be61de8a6f7cdf412efbcc7bafe7f8f)
• [x] Everything works correctly on Windows 32-bit platform (https://github.com/sircharlo/meeting-media-manager/commit/b92db40c75e7bac09c4b7e2395948498ae1e62a7)
• [x] mp3 to mp4 conversion works correctly (https://github.com/sircharlo/meeting-media-manager/pull/629/commits/412238bdefec285beef2f105e17103abfede015c)

[sircharlo]

Hm.

Error: CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 3c 21 64 6f @+0

[sircharlo]

WebAssembly.instantiate(): expected magic word

Perhaps related to https://github.com/WebAssembly/spec/issues/1031

[sircharlo]

Duh. Ran the equivalent prebuild commands.

[mtdvlpr]

I tested Malagasy and image zoom/pan. No issues on my end.

[sircharlo]

Check out my new commit, it improves the display of images when the aspect ratio isn't exactly 16:9.

[sircharlo]

MP3 to MP4 worked fine, ffmpeg download and ran the conversion. The progress bar didn't disappear, but not a major issue IMO.

[sircharlo]

MP3 to MP4 worked fine, ffmpeg download and ran the conversion. The progress bar didn't disappear, but not a major issue IMO.

This is what is displayed after the conversion finishes. No errors in console.

[mtdvlpr]

Strange that it doesn't go to 100%. After it reaches 100%, it will reset and dissapear

[mtdvlpr]

Found it. It doesn't call setProgress in the mp3 if branch

[sircharlo]

I'll test the following on Win32:

• [x] sync
• [x] cong sync
• [x] cong upload
• [x] cong delete
• [x] image convert of PDFs
• [x] MP4 convert of images and MP3s (MP3s not working)
• [x] media playback window
• [x] zoom/pan
• [x] background music

[mtdvlpr]

I'll test the following on Win32:

Awesome! Afterwards I think we're good to go with the release :) The Sentry issues that are still open can't be pinned down to a fix (yet), so I'll set them to resolved in next release.

[sircharlo]

For some reason, lff isn't extracting properly on Win32. Other publications are, but not lff. Hmm. The JWPUB file gets downloaded, but not extracted. M3 logs.-1667768249921.log

[sircharlo]

Are we possibly hitting some sort of memory issue on low-memory systems, since we're loadAsync'ing the JWPUB files into memory before extracting them?

[mtdvlpr]

Might be related to this

[sircharlo]

Might be related to this

I'll wait for the build to finish and try it out with the updated try/catches

[sircharlo]

Here's something interesting. The JWPUB file doesn't seem to be downloaded properly.

[mtdvlpr]

Ah okay. We're missing a check to see if the jwpub file is valid. No wait, we do check if the cached file size is equal to the file size from the api call

[sircharlo]

I deleted the 0kb JWPUB file to see what happens.

1. Click blue button
2. JWPUB file starts getting downloaded
3. Zipper seems to attempt to extract JWPUB file before download is complete
4. JWPUB file seems to change size alot, almost as if it's being downloaded twice simultaneously and overwriting the same file?!
5. Error message
6. Windows folder now shows the whole JWPUB file

[mtdvlpr]

That would be in line with the stackoverflow answer:

I believe you would get this error after you stop your execution in between, i.e when the file is getting updated and this would corrupt the excel file.

[mtdvlpr]

Maybe because of the async execution the lff file is referenced multiple times and therefore download multiple times at the same time. You could look at the network tab to see if that's the case

[sircharlo]

Maybe because of the async execution the lff file is referenced multiple times and therefore download multiple times at the same time. You could look at the network tab to see if that's the case

Bingo.

[sircharlo]

"Both" files get downloaded at the same time, overwriting the same file. Zipper errors out on the first execution because the download from the second execution is still happening.

[sircharlo]

I can confirm that running the sync once the lff file has been fully downloaded (by a previous sync) results in a correctly unzipped lff folder and no further errors.

[sircharlo]

Makes sense that this is a new issue, seeing as pre-refactor, publications were always downloaded sequentially. If a pub already existed because it had been previously downloaded (no matter if it was 1 minute or 1 month ago), then the download was simply skipped.

This is definitely a scenario that would need to be accounted for, as I could see this causing errors in real-world usage, especially on newer installations that don't have publications like lff cached yet.

[sircharlo]

Would there be a way to modify downloadIfRequired to:

• check if a publication id has been queued for download

If it has:

• resolve when the existing, queued download is complete

If it hasn't:

• add the publication id to the queue, and
• start the download
• resolve when the download is complete

[mtdvlpr]

Working on it

[mtdvlpr]

see #634

[mtdvlpr]

It seems to work, because I'm now only seeing one call after clearing the cache and no errors

[mtdvlpr]

@sircharlo, can you check if it also works on win32?

[mtdvlpr]

I'm signing off. Time to go to sleep😴

[sircharlo]

@sircharlo, can you check if it also works on win32?

Negative, unfortunately.

Probably related to the low amount of memory of 32-bit systems (https://stackoverflow.com/questions/45920143/how-to-handle-array-buffer-allocation-failed-in-nodejs)

Edit: the error went away after relaunching the app, so I'm gonna call this a "you should really have more than 4GB of RAM to run media at meetings" situation.

Other than that, the repetitive-download behavior is in fact gone.

[sircharlo]

Slight regression introduced, see https://github.com/sircharlo/meeting-media-manager/pull/634#issuecomment-1304952468

[mtdvlpr]

Slight regression introduced, see #634 (comment)

Fixed in #635

[mtdvlpr]

I got my virtual Windows 32-bit machine working too! Everything seems to work, except converting mp3 to mp4. That goes wrong every time. The error is now caught and a human friendly warning is given. Since converting mp3 to mp4 is a real edge case, and it only goes wrong on (low-memory?) 32-bit machines, I'd say forget about it.

[sircharlo]

I got my virtual Windows 32-bit machine working too! Everything seems to work, except converting mp3 to mp4. That goes wrong every time. The error is now caught and a human friendly warning is given. Since converting mp3 to mp4 is a real edge case, and it only goes wrong on (low-memory?) 32-bit machines, I'd say forget about it.

Even worse, it works for me in Win32 😆 But agreed, not the end of the world.

[mtdvlpr]

Haha, then it's probably a memory thing.

[mtdvlpr]

I'd say we're good to go then

[sircharlo]

Will you do the honors, or me?

[mtdvlpr]

It's easier for you, since you can push directly to master. I'd have to create a pull request which I'm not sure has the desired outcome.

[mtdvlpr]

@sircharlo, so what happened is you wanted to push the release commit, but got blocked because you had to git pull first. Then when you pushed the merge commit got evaluated instead of the release commit, so no release workflow was executed. You'll have to do another chore(release)

[sircharlo]

@sircharlo, so what happened is you wanted to push the release commit, but got blocked because you had to git pull first. Then when you pushed the merge commit got evaluated instead of the release commit, so no release workflow was executed. You'll have to do another chore(release)

Yeah my bad, I redid it and it worked after. :)

[sircharlo]

Weirdly enough, the autoupdate didn't work for me until I deleted the %localappdata%\meeting-media-manager-updater folder.

[mtdvlpr]

Hmm, it worked fine for me. The desktop shortcut also correctly updated this time.

[mtdvlpr]

Did you have a locally generated version installed by chance?

[sircharlo]

Nah, I didn't build on my machine at all. Must be a glitch with my setup, I wouldn't worry about it too much