search

sircharlo / meeting-media-manager

A cross platform app to download and present media (pictures and videos) for congregation meetings of Jehovah’s Witnesses in any language. Features include recurring and custom media management, congregation sync, and media presentation tools for hybrid, in-person or fully remote Zoom meetings.
GNU Affero General Public License v3.0
133 stars 23 forks source link

[BUG] Congregation sync removal only takes place after app restart #868

Closed sircharlo closed 1 year ago

sircharlo commented 1 year ago

Describe the bug Congregation sync removal only takes place after app restart

To Reproduce Steps to reproduce the behavior:

  1. Set up congregation sync
  2. Do a sync
  3. Try to upload a file to server
  4. Unset congregation sync from settings (remove all congregation sync related settings)
  5. Try to add a custom file to media list for a certain day by clicking on day icon
  6. App tries to upload files to congregation server, even though it is no longer configured in settings

Expected behavior The congregation server should no longer be used as soon as it is removed from the settings.

mtdvlpr commented 1 year ago

Hmm, I can't seem to replicate this. In what order are you removing the cong sync settings?

joaochris commented 1 year ago

Hmm, I can't seem to replicate this. In what order are you removing the cong sync settings? Screenshot_1

Screenshot_2

Is it if it isn't? After removing the server it appears as if it is connecting to the server. In image 2 it is after removing the server, after downloading the media.

mtdvlpr commented 1 year ago

Is it if it isn't? After removing the server it appears as if it is connecting to the server. In image 2 it is after removing the server, after downloading the media.

That, as it turns out, is just a bug where the statistics are not cleared after a media sync. Fixed in c6f5158edee2ea38d5c03997dc10dc008a994c48. It's listing old statistics from a previous fetch.

mtdvlpr commented 1 year ago

@sircharlo, could you provide some more details on the procedure to replicate this issue?

sircharlo commented 1 year ago

Ok, I'll whip up some screenshots from scratch

sircharlo commented 1 year ago

Well then. I can't reproduce this for the life of me, but I swear it happened.

sircharlo commented 1 year ago

Ever heard of Mr. Snuffleupagus?