search

sirchia / pimatic-rflink

RFLink plugin for Pimatic
GNU General Public License v2.0
3 stars 5 forks source link

Receiving new dimmer value causes crash #12

Closed Redferne closed 8 years ago

Redferne commented 8 years ago

When a dimmer device is set externally (using original remote) this causes crash below:

warn [pimatic]: Keeping pimatic alive, but could be in an undefined state, please restart pimatic as soon as possible! 22:26:53error [pimatic]: A uncaught exception occured: AssertionError: false == true at RFLinkDimmer.DimmerActuator._setDimlevel (/home/pi/pimatic-app/node_modules/pimatic/lib/devices.coffee:358:7) at RFLinkDimmer._setDimlevel (/home/pi/pimatic-app/node_modules/pimatic/lib/devices.coffee:1:1) at Board. (/home/pi/pimatic-app/node_modules/pimatic-rflink/rflink.coffee:204:18) at emitOne (events.js:82:20) at Board.emit (events.js:169:7) at Board._processData (/home/pi/pimatic-app/node_modules/pimatic-rflink/lib/board.coffee:129:11) at SerialPortDriver. (/home/pi/pimatic-app/node_modules/pimatic-rflink/lib/board.coffee:43:8) at emitOne (events.js:77:13) at SerialPortDriver.emit (events.js:169:7) at SerialPort. (/home/pi/pimatic-app/node_modules/pimatic-rflink/lib/serialport.coffee:37:8) at emitOne (events.js:77:13) at SerialPort.emit (events.js:169:7) at /home/pi/pimatic-app/node_modules/pimatic-rflink/node_modules/serialport/parsers.js:25:17 at Array.forEach (native) at Object.parser (/home/pi/pimatic-app/node_modules/pimatic-rflink/node_modules/serialport/parsers.js:24:13) at Object.SerialPort.opts.dataCallback (/home/pi/pimatic-app/node_modules/pimatic-rflink/node_modules/serialport/serialport.js:181:12) at SerialPortFactory.SerialPort._emitData (/home/pi/pimatic-app/node_modules/pimatic-rflink/node_modules/serialport/serialport.js:396:20) at afterRead (/home/pi/pimatic-app/node_modules/pimatic-rflink/node_modules/serialport/serialport.js:372:20) at /home/pi/pimatic-app/node_modules/pimatic-rflink/node_modules/serialport/serialport.js:388:9 at FSReqWrap.wrapper as oncomplete This is most probably a bug in pimatic or in a module, please report it!

22:26:53debug [pimatic-rflink]: data: "20;56;NewKaku;ID=0353b832;SWITCH=1;CMD=SET_LEVEL=15;"

sirchia commented 8 years ago

Thanks for reporting this issue. I pushed some changes that should fix it, but I don't have the necessary devices to test it out. Can you try out the current master branch to see if the issue is fixed and post your results here. I will make a new release if the tests are successful.

Redferne commented 8 years ago

Latest @master works perfectly. Thank you!

sirchia commented 8 years ago

Issue closed. Bugfix in release 0.6.0