search

sirchia / pimatic-rflink

RFLink plugin for Pimatic
GNU General Public License v2.0
3 stars 5 forks source link

RFLinkShutter ? #17

Open warde265 opened 7 years ago

warde265 commented 7 years ago

Hi Sirchia,

In the future (9/2017) , I'll try to use this plugin with shutter (RTS). I see in the code that RFLinkShutter classe is in comment. Do I have to only uncomment this to work with ? Or is this code always in development ? Or not yet tested ? If you need someone to test, I can do it.

Thanks & regards, Christophe

sirchia commented 7 years ago

Initially, the project was copied from homeduino plugin as it was very similar. Basic replacements from homeduino to RFLink (e.g. find-replace of the name) were done, but afterwards all code for device classes I could not test (as I don't have the corresponding devices) were put into comments.

During the lifetime of this project, several users have uncommented missing devices (e.g. PIRs, data sensors) and corrected the original homeduino code to make it work correctly for RFLink.

If you could look into it, uncommenting the corresponding code and adapting it to be similar to the switch logic (I suspect it will be very similar) and testing it with your devices, I will be happy to merge a PR with you changes.

Unfortunately I won't have much time in the coming months due to vacation, moving and house renovations etc.

warde265 commented 7 years ago

Thanks for your reply ! I will try to change the code in few months. If it works, then I will give you the code.

hofaa commented 3 years ago

Hey there! I know this thead is old but I wanted to contribute since I implemented RFLinkShutter for my installation. Let me know if you are interested and how to send you the amended coffee script @sirchia

Cheers