search

sirduney / dunes-cli

CLI for minting dunes
MIT License
23 stars 23 forks source link

Ensuring support for both emojis and the symbol "Đ" for Đogecoin😉 #1

Closed GreatApe42069 closed 6 months ago

GreatApe42069 commented 8 months ago

Now, the isValidSymbol function checks for both emojis and the symbol "Đ" for Doge. The script will now validate whether the provided symbol is a valid emoji or the specified symbol. The provided modification includes the enhanced validation for symbols, ensuring support for both emojis and the symbol "Đ." Replaced the existing isSingleEmoji function with the updated isValidSymbol and I added the isSingleEmoji function for further emoji validation. Haven't got a chance to try it out yet though.

sirduney commented 7 months ago

Thanks for the PR. Can you please use the same code formatting as on master so that the diff only contains your changes?

GreatApe42069 commented 7 months ago

I just resynced your original Repo to my forked repo, so all changes including all new commits from your end and also all my changes and differences should be showing properly now. If not let me know what you need me to do to and I'll fix it.

On Mon, Apr 15, 2024, 6:47 AM Sir Duney @.***> wrote:

Thanks for the PR. Can you please use the same code formatting as on master so that the diff only contains your changes?

— Reply to this email directly, view it on GitHub https://github.com/sirduney/dunes-cli/pull/1#issuecomment-2056527400, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEWWEIC5R62FBR5A6NN26Y3Y5OV2NAVCNFSM6AAAAABEDY736SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGUZDONBQGA . You are receiving this because you authored the thread.Message ID: @.***>

sirduney commented 7 months ago

Having a look today ☝️

sirduney commented 7 months ago

There's still a noticeable difference in formatting. If you can adjust it so that the code isn't reformatted, I'll be able to merge it. Alternatively, I can handle the changes manually if you prefer. Check out this line for reference.

GreatApe42069 commented 7 months ago

Yea if you could handle it that would be great, I can just resync my fork after you update so everyone has latest version.

On Thu, Apr 18, 2024, 7:12 AM Sir Duney @.***> wrote:

There's still a noticeable difference in formatting. If you can adjust it so that the code isn't reformatted, I'll be able to merge it. Alternatively, I can handle the changes manually if you prefer. Check out this line https://github.com/sirduney/dunes-cli/pull/1/files#diff-14700dbd900932e53edad97e61ec2f1757de308567c8c17f52498337eb216b16L850 for reference.

— Reply to this email directly, view it on GitHub https://github.com/sirduney/dunes-cli/pull/1#issuecomment-2063615449, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEWWEIGKRJRTWW3AMQUS5RLY56TBDAVCNFSM6AAAAABEDY736SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGYYTKNBUHE . You are receiving this because you authored the thread.Message ID: @.***>