search

sireliah / dragit

Application for intuitive file sharing between devices.
GNU General Public License v3.0
140 stars 4 forks source link

Punch hole in firewalld #12

Closed sireliah closed 3 years ago

sireliah commented 3 years ago

This is a change that makes Dragit automatically detect if firewalld is going to prevent the application from listening on required ports. For more info, please check #9

sp1ritCS commented 3 years ago

If you want to save it permanently I think you should do so over a firewall rule, not just by adding the port to the list of open ports, as a user checking firewall-config later on will have no idea why the port is there.

sireliah commented 3 years ago

If you want to save it permanently I think you should do so over a firewall rule, not just by adding the port to the list of open ports, as a user checking firewall-config later on will have no idea why the port is there.

Do you mean the addRule from direct config or a rich rule? None of them have any comment section and direct rules are hidden by default in firewall-config, so it might not be much better. Or you meant something different?

I also thought about the zone, but zone is not in use unless you attach it to a connection or make a default zone, which creates all sorts of problems.

sp1ritCS commented 3 years ago

Yeah, my bad. I was talking about "services" (the files in /usr/lib/firewalld/services/*.xml)

sireliah commented 3 years ago

firewall_prompt

@sp1ritCS Now there is separate "dragit" service with description. Please take a look if you like.

sp1ritCS commented 3 years ago

Great!

looks good from my side 👍🏻