search

sirensolutions / siren-join

[This is the old, single node version for Elasticsearch 2.x, see the latest "Siren Federate" plugin for distributed Elasticsearch 5.x and 6.x capabilities]
http://siren.io
GNU Affero General Public License v3.0
183 stars 60 forks source link

Upgraded to 2.4.5 #134

Closed breisig closed 7 years ago

breisig commented 7 years ago

I can now build the package and get the zip installed on Elasticsearch 2.4.5

CLAassistant commented 7 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Boris Reisig seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

rendel commented 7 years ago

Hi @breisig, thanks. Two comments:

  1. We should upgrade the lucene dependency to 5.5.4. See https://github.com/elastic/elasticsearch/commit/d8fd32baa86fd943b91619cf5af3ac8b869f8f4f.

  2. Could you please create the PR against the develop branch instead of master.

Thanks

szydan commented 7 years ago

@breisig Thank you for your contribution, however, I have to close this one in favour of https://github.com/sirensolutions/siren-join/pull/135