Issue #22 - Githubissues

sirensolutions / siren-join

[This is the old, single node version for Elasticsearch 2.x, see the latest "Siren Federate" plugin for distributed Elasticsearch 5.x and 6.x capabilities]

http://siren.io

GNU Affero General Public License v3.0

183 stars 60 forks source link

Issue #22 #24

Closed rendel closed 8 years ago

scampi commented 8 years ago

looks good. I will test the branch with kibi.

rendel commented 8 years ago

ok thanks, I'll merge when your test will be successful.

scampi commented 8 years ago

README needs to be updated:

    Plugins can be installed from a custom URL or file location as follows:

        plugin install http://some.domain.name//my-plugin-1.0.0.zip
        plugin install file:/path/to/my-plugin-1.0.0.zip

plugin-descriptor.properties file missing: https://www.elastic.co/guide/en/elasticsearch/plugins/2.1/plugin-authors.html

scampi commented 8 years ago

nit-pick: in the README, we should say that for version 1.0, the plugin name is "FilterJoinPlugin".