sirensolutions / siren-join

[This is the old, single node version for Elasticsearch 2.x, see the latest "Siren Federate" plugin for distributed Elasticsearch 5.x and 6.x capabilities]
http://siren.io
GNU Affero General Public License v3.0
183 stars 60 forks source link

Cache key must be based on a version number of the source index #73

Closed rendel closed 8 years ago

rendel commented 8 years ago

Currently the cache key is generated from the join query definition. However, the data in the index can change and two identical queries can return different result sets. Given that the cache key is used in the lucene query cache and in the siren join cache, this can lead to incorrect results. Instead, we have to create a cache key that will be dependent on the version of the source index.