search

sireum / archived-v2-amandroid

34 stars 16 forks source link

Added HideAPI_run.scala #56

Closed kaushin closed 8 years ago

kaushin commented 8 years ago

Code to detect API that hides icon from app drawer

fgwei commented 8 years ago

LGTM. But some general suggestion,

  1. Never use hard coded paths, if you really need, you can pass it as an argument for your program.
  2. Don't leave unnecessary commented code.
  3. Instead of create two pull requests for two files which dependent with each other, just create one pull request with everything.

I also revised your two files, to make it more lightweight and clean.

kaushin commented 8 years ago

Sorry, im not really used to doing pull requests, will do better next time. Again apologies.

fgwei commented 8 years ago

It's fine, looking forward to get more interesting code from u.