sirgwain / craig-stars

Web based Stars! clone
https://craig-stars.net
MIT License
10 stars 4 forks source link

Costcalculation of Starbases is wrong #279

Open ccmaster001 opened 1 month ago

ccmaster001 commented 1 month ago

Starbases have to be much cheaper.

sirgwain commented 1 month ago

Can you give me an example of a star base build in stars vs craig-stars? The cost should just be components plus hull

Bertie690 commented 1 week ago

From what I can tell at least, the cost calcs are incorrect for weapons/armor added onto starbases - starbases should have an innate 50% discount compared to normal price (a discount not appearing to apply for craig-stars).

sirgwain commented 1 week ago

weapons and armor cost 50% less to mount to starbases? wow. that might explain this issue... https://github.com/sirgwain/craig-stars/issues/279

Bertie690 commented 1 week ago

Yes - I'm 90% confident it was done to balance out starbases' high baseline hull costs & immobility. I need to check what parts the 50% discount specifically applies to (orbitals don't count, but IDK about electrical).

Bertie690 commented 1 week ago

Ok after further testing, it appears that starbases get a 50% innate stackable discount on everything EXCEPT orbital devices (which makes sense since those can only go on starbases). The costs appear to be tabulated as a float and then rounded up at the end.

ccmaster001 commented 1 week ago

Stacky with ISB and the I T get a discound for gates.