sirgwain / craig-stars

Web based Stars! clone
https://craig-stars.net
MIT License
10 stars 4 forks source link

Lots of bombed planets look wrong #348

Open ccmaster001 opened 3 months ago

ccmaster001 commented 3 months ago

image

image

sirgwain commented 3 months ago

What looks wrong about it?

ccmaster001 commented 3 months ago

well it has 0 People !!!! Shows 9800 in the other overview and its marked as colonized not empty

sirgwain commented 3 months ago

Ah, you killed off all colonists but your bombers don't have scanners so they didn't update.

All ships have a non-pen scanner range 0. I need to update the scan logic to detect ownership on non-pen scans, while in orbit. That way you can know if a planet was emptied or not, but not learn anything else about it.

ccmaster001 commented 3 months ago

NO!!! It is my Planet ! I got Bombed. It has not updated correct.

  1. is Correct McBride 0 Kolonists
  2. is incorrect 9800 kolonists
  3. the ownership of the planets is still there.
  4. I think the scan gets not updated as i have there no ships and no planet any more, there has to be a check in the logic for 0 Kolonists
sirgwain commented 3 months ago

Oh! You lost the planet but still think you own it. Got it.

ccmaster001 commented 3 months ago

the game thinks i own it and so i have to click a lot of planets to check they dont exist any more

Am Mo., 19. Aug. 2024 um 18:51 Uhr schrieb sirgwain < @.***>:

Oh! You lost the planet but still think you own it. Got it.

— Reply to this email directly, view it on GitHub https://github.com/sirgwain/craig-stars/issues/348#issuecomment-2297010402, or unsubscribe https://github.com/notifications/unsubscribe-auth/BISPY2XDSADN47SV5UIAX4LZSIPA3AVCNFSM6AAAAABMWNBOD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGAYTANBQGI . You are receiving this because you authored the thread.Message ID: @.***>