sirhamsteralot / HaE-PBLimiter

Profiles pb's and damages them when their runtime goes over a set value
MIT License
11 stars 5 forks source link

PBLimiter does nothing #31

Closed Sigurdovich closed 6 days ago

Sigurdovich commented 4 years ago

Hello there,

Seems plugin does nothing !pblimiter status return empty window

pblimiter

azazar commented 4 years ago

Are you sure that you have PBs running at that moment?

Sigurdovich commented 4 years ago

Torch say plugin loaded How can i check plugin running or not? My server place on hosting pingperfect.com and i have no GUI for dedicated server and Torch

PBs running

plugin3

plugin2

plugins

azazar commented 4 years ago

!pblimiter status displays stats for only PBs owned by local player and which have been executing scripts within configured timeout. It's not displaying just all PBs that the server is running. To check if it's running setup PB with script that won't fit within allowed exection time. Something like that:

Program()
{
    Runtime.UpdateFrequency = UpdateFrequency.Update1;
}

void Main() {
    for(int i = 0; i < 500; i++)
    {
        Me.CustomData = "" + i;
    }
}
klemens-st commented 4 years ago

I have the exact same problem. The plugin doesn't work on a server without GUI. I tested same save file both on a server with and without GUI.

@azazar On a no GUI server with PBLimiter loaded the script you posted broke the server, the plugin didn't stop it.

sirhamsteralot commented 4 years ago

that makes absolutely no sense why it wouldnt work, ill have to look into it none of the actual logic of the plugin is tied to the UI sooo....

klemens-st commented 4 years ago

A bit more information: at first I thought it might be a problem with the rented server I'm using but I've just launched Torch locally with <NoGui>true</NoGui> and the problem is exactly the same.

sirhamsteralot commented 4 years ago

can i see your full config for pblimiter?

klemens-st commented 4 years ago
<?xml version="1.0" encoding="utf-8"?>
<ProfilerConfig xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <SerializeWrapTicks>20</SerializeWrapTicks>
  <SerializeWrapViolationsMult>0.1</SerializeWrapViolationsMult>
  <SerializeWrapTime>0.2</SerializeWrapTime>
  <SerializeWrapTimeOutTime>300</SerializeWrapTimeOutTime>
  <SerializeWrapSignificance>0.005</SerializeWrapSignificance>
  <SerializeWrapPerPlayer>true</SerializeWrapPerPlayer>
  <SerializeWrapAllowCleanup>true</SerializeWrapAllowCleanup>
  <SerializeWrapPlayerOverrides>
    <Player>
      <Name>zymeth</Name>
      <SteamId>0</SteamId>
      <PersonalMaxMs>10</PersonalMaxMs>
      <OverrideEnabled>true</OverrideEnabled>
    </Player>
  </SerializeWrapPlayerOverrides>
  <TakeIngameMeasurement>true</TakeIngameMeasurement>
</ProfilerConfig>
klemens-st commented 4 years ago

It works fine with GUI enabled.

Tobiti commented 3 years ago

I have the same problem

Tobiti commented 3 years ago

I found the problem In PBData.cd line 37 you check for UserControl and its null so you just return. So instead of just returning, add the date too

klemens-st commented 3 years ago

Well spotted, I remember looking through the code back then but I missed this one.

sirhamsteralot commented 6 days ago

Thanks for the chats guys, i will have a look at implementing it in the next round of fixes! (yes i know this is like 3 years later but im getting back in the game now)

sirhamsteralot commented 6 days ago

Resolved in 2024-1 upstream. you can find the fix in the next release!