Closed mycroftjr closed 3 months ago
@sirinsidiator
Good find. zo_combobox go that too, I simply missed it: https://github.com/esoui/esoui/blob/7d5ebebfe4124ff4de44de89ef5d6f4287d669fb/esoui/libraries/zo_combobox/zo_combobox.lua#L31
Thanks. Can confirm that this fixes the issue as described. Next time please make sure to increment the widget version too.
Oh right, I'll try to remember to do that if I need to make any other changes :)
https://github.com/Baertram/ESO-LibAddonMenu/blob/master/LibAddonMenu-2.0/controls/dropdown.lua#L73-L97 currently only clears dropdown.m_selectedItemData, but m_enableMultiSelect dropdowns use m_multiSelectItemData instead. Because that isn't cleared, dropdown:SetSelectedItemByEval resolves eventually into SelectItem (which, in /EsoUI/Libraries/ZO_ComboBox/ZO_ComboBox.lua:341, self:RemoveItemFromSelected(item) if the item was already self:IsItemSelected(item) ). So ultimately, UpdateMultiSelectSelected currently untoggles everything when called (for multiSelect only). This fixes that by clearing m_multiSelectItemData also.
For clarification, the repro steps: