search

sirinsidiator / ESO-LibAddonMenu

http://www.esoui.com/downloads/info7-LibAddonMenu.html
Artistic License 2.0
42 stars 20 forks source link

Let text fields use standard ESO localization #22

Closed skyeskie closed 8 years ago

skyeskie commented 9 years ago

Allow the item name, tooltip, description, and other text display take in a string ID for localization instead of a string.

Example current:

LAMCreateControl.checkbox(parent, {
        type = "checkbox",
        name = GetString(SI_SOME_CHECKBOX_NAME),
        tooltip = GetString(SI_SOME_CHECKBOX_TOOLTIP),
        -- ....
}

With change:

LAMCreateControl.checkbox(parent, {
        type = "checkbox",
        name = SI_SOME_CHECKBOX_NAME,
        tooltip = SI_SOME_CHECKBOX_TOOLTIP,
        -- ....
}

This would be a simple type check since IDs are integers. Not really necessary, but would be a nice integration to promote localizing.

sirinsidiator commented 8 years ago

Has been implemented for all name, tooltip and warning values. Dropdowns may also profit from this, but there are some other changes necessary before it will work. Going to handle this in a separate ticket.