search

sirinsidiator / ESO-LibAddonMenu

http://www.esoui.com/downloads/info7-LibAddonMenu.html
Artistic License 2.0
41 stars 20 forks source link

Update warning tooltips during panel refresh. #55

Closed silvereyes333 closed 8 years ago

silvereyes333 commented 8 years ago

I needed the ability to have the warning icon refresh its tooltip or completely hide (if warning was set to a function that returns nil) during a panel refresh for one of my addons. So I went ahead and implemented the feature for all widgets that have a warning setting. Code provided here in case you think it's worth including in the next release. No offense if you don't want it, though.

sirinsidiator commented 8 years ago

I guess for LAM2.0 it is okay to add it, but it will probably disappear again with the changes I have in mind for LAM3.0.

If I didn't miss anything, all of the UpdateWarning functions are identical, so please move it to LibAddonMenu-2.0.lua and assign it to LAM.util.UpdateWarning instead of redefining it in every file. Also do not forget to update the widget versions for those that have not had it updated yet since the r21 release.

silvereyes333 commented 8 years ago

Gah. Sorry about the version numbers. I just refactored the shared util UpdateWarnings and bumped versions for all widgets in this PR except slider, which was already bumped.

sirinsidiator commented 8 years ago

I should have merged it before I made my own changes... Can you please take a look and fix it?