sirinsidiator / ESO-LibAddonMenu

http://www.esoui.com/downloads/info7-LibAddonMenu.html
Artistic License 2.0
42 stars 20 forks source link

Scrollable dropdown #83

Closed Baertram closed 5 years ago

Baertram commented 6 years ago

The scrollabale dropdown box within LAM is always using the standard value of 10 items for the scrollbar, even if there is only 1 entry in the dropdown box.

The variable DEFAULT_VISIBLE_ROWS is used in line 347 if the "scrollable" parameter is a boolean e.g.: local visibleRows = type(dropdownData.scrollable) == "number" and dropdownData.scrollable or DEFAULT_VISIBLE_ROWS

But if the number of rows in the dropdowns entries is below this default value of 10 rows, the scrollbar is too long/high.

Example, scrollable parameter = true, so DEFAULT_VISIBLE_ROWS will be used (10 lines): image

This should also apply to if the scrollable parameter is specified as an integer value. If this is > entries in the dropdown the scrollbar will be too high too.

sirinsidiator commented 5 years ago

fixed in r27