search

sirinsidiator / ESO-LibAddonMenu

http://www.esoui.com/downloads/info7-LibAddonMenu.html
Artistic License 2.0
41 stars 20 forks source link

color picker throws error in gamepad mode #94

Closed sirinsidiator closed 5 years ago

sirinsidiator commented 5 years ago

User Gandalf reported the following error in the comments on ESOUI:

EsoUI/Libraries/ZO_Dialog/Gamepad/ZO_GenericDialog_Gamepad.lua:280: attempt to index a nil value
stack traceback:
    EsoUI/Libraries/ZO_Dialog/Gamepad/ZO_GenericDialog_Gamepad.lua:280: in function 'ZO_GenericGamepadDialog_SetupDirectionalInput'
    EsoUI/Libraries/ZO_Dialog/Gamepad/ZO_GenericDialog_Gamepad.lua:521: in function 'ZO_GenericGamepadDialog_Show'
    EsoUI/Libraries/ZO_Dialog/ZO_Dialog.lua:739: in function 'ZO_Dialogs_ShowDialog'
    (tail call): ?
    EsoUI/Libraries/ZO_Dialog/ZO_Dialog.lua:328: in function 'ZO_Dialogs_ShowGamepadDialog'
    EsoUI/Libraries/ZO_Dialog/ZO_Dialog.lua:265: in function 'ZO_Dialogs_ShowPlatformDialog'
    EsoUI/Common/ZO_ColorPicker/ZO_ColorPicker_Shared.lua:136: in function 'ZO_ColorPicker_Shared:Show'
    user:/AddOns/LuiExtended/libs/LibAddonMenu-2.0/controls/colorpicker.lua:82: in function '(anonymous)'

We don't actually support gamepad mode yet, but he proposed the following change.

if IsInGamepadPreferredMode() then
    COLOR_PICKER_GAMEPAD:Show(ColorPickerCallback, r, g, b, a, LAM.util.GetStringFromValue(colorpickerData.name))
else
    COLOR_PICKER:Show(ColorPickerCallback, r, g, b, a, LAM.util.GetStringFromValue(colorpickerData.name))
end

See if this works, otherwise it will have to wait until LAM3.0.