search

sirinsidiator / ESO-LibAddonMenu

http://www.esoui.com/downloads/info7-LibAddonMenu.html
Artistic License 2.0
41 stars 20 forks source link

Minimal comment cleanup and UI warning color. #96

Closed phuein closed 5 years ago

phuein commented 5 years ago

Minimally fix comments' readability. Good preparation for updating the comments.

Also, the red color of the RELOAD_UI_WARNING text was killing my eyes, so I added a panel.data option to set it. Defaults to nil -> default color. Includes new panel table comment. And warning text was shortened for readability.

A small README to help direct new visitors to the docs they're likely wanting.

sirinsidiator commented 5 years ago

The changes to the comments seem fine and I could merge them right away if you split them into a separate request.

As for the reload ui warning, instead of adding a property for the color I'd rather keep it consistent across addons and use a different color for all of them. Seeing as the ingame video settings do not color it at all, we could probably just drop the red. In addition we should also use the same text for the tooltip as is used there.

phuein commented 5 years ago

Agreed.

I'll close this pull, make a new pull only for "Table comments cleanup", and make another pull to finalize the reload warning message topic - default color and default game text for it. (Jeez I'm glad you agree with removing the red color in any way hah.) And finally a small pull req' for the readme, too.

sirinsidiator commented 5 years ago

How fast do you believe you can implement the changes to the reload warning? Should I wait before I release r29 or will it take longer?

phuein commented 5 years ago

As fast as you approve every gradual pull. :D (Jeez Git is annoying.) Let me pull up the next one then.

Sorry, GitHub is trying to make a pull request with both commits - including the one you just approved. It doesn't see your Master already has it. Trying to figure it out.