search

siriobelli / flame

Flame data reduction pipeline
4 stars 4 forks source link

Most recent version doesn't perform cosmic ray subtraction #12

Closed tomjf closed 7 years ago

tomjf commented 7 years ago

For some reason after the exptime/elaptime fix flame_correct does not perform the L.A.Cosmic cosmic ray detection

siriobelli commented 7 years ago

Did you make sure to set the fuel.util.clean_individual_frames flag to 1 after the initialization?

tomjf commented 7 years ago

Not initially. I had this in the driver.


  ; there are lots of cosmic rays on each individual frame
  input.clean_individual_frames = 1

  ;**********************************
  ;**********************************

  ; initialize and create the fuel structure
  fuel = flame_initialize_lris(input)

I tried with this

  ; there are lots of cosmic rays on each individual frame
  input.clean_individual_frames = 1

  ;**********************************
  ;**********************************

  ; initialize and create the fuel structure
  fuel = flame_initialize_lris(input)
  input.clean_individual_frames = 1

and it made no difference.

Why would it matter whether you set this parameter before or after the initialization?

tomjf commented 7 years ago

oops I realise the final line should probably be

fuel.input.clean_individual_frames = 1

Still doesn't make a difference though.

siriobelli commented 7 years ago

It's in the fuel.util structure, not fuel.input! If you run fuel.input.clean_individual_frames = 1 you should get an error because there is no such field in fuel.input.