search

sirixdb / sirix

SirixDB is an an embeddable, bitemporal, append-only database system and event store, storing immutable lightweight snapshots. It keeps the full history of each resource. Every commit stores a space-efficient snapshot through structural sharing. It is log-structured and never overwrites data. SirixDB uses a novel page-level versioning approach.
https://sirix.io
BSD 3-Clause "New" or "Revised" License
1.09k stars 244 forks source link

fix: fix sonar issues #671

Closed Naman0133 closed 8 months ago

Naman0133 commented 8 months ago

Issue: #440

welcome[bot] commented 8 months ago

Thanks so much for opening this pull request and for helping to improve SirixDB 🚀

JohannesLichtenberger commented 8 months ago

Can you format your changes with the SirixDB formatter?

Naman0133 commented 8 months ago

yess sure

On Sat, 14 Oct 2023 at 6:46 PM, Johannes Lichtenberger < @.***> wrote:

Can you format your changes with the SirixDB formatter?

— Reply to this email directly, view it on GitHub https://github.com/sirixdb/sirix/pull/671#issuecomment-1762891785, or unsubscribe https://github.com/notifications/unsubscribe-auth/APK4O4CRKEHGVJF6ZOH7XQDX7KGC5ANCNFSM6AAAAAA6AAR4XE . You are receiving this because you authored the thread.Message ID: @.***>

Naman0133 commented 8 months ago

Can you format your changes with the SirixDB formatter?

I am seeing all checks are passing, can you tell me is formatter needed ? if yes then how to do?

JohannesLichtenberger commented 8 months ago

There's a SirixDB.xml formatter you can import in Eclipse or IntelliJ.

Naman0133 commented 8 months ago

There's a SirixDB.xml formatter you can import in Eclipse or IntelliJ.

ohh okay will try and update the code

Naman0133 commented 8 months ago

There's a SirixDB.xml formatter you can import in Eclipse or IntelliJ.

Done, can you please review it now? Thanks :)

welcome[bot] commented 8 months ago

Congrats on merging your first pull request. 🐬 You've just improved SirixDB for everyone. ❤️

Naman0133 commented 8 months ago

@JohannesLichtenberger Please add the hacktoberfest-accepted label