search

sirixdb / sirix

SirixDB is an an embeddable, bitemporal, append-only database system and event store, storing immutable lightweight snapshots. It keeps the full history of each resource. Every commit stores a space-efficient snapshot through structural sharing. It is log-structured and never overwrites data. SirixDB uses a novel page-level versioning approach.
https://sirix.io
BSD 3-Clause "New" or "Revised" License
1.12k stars 251 forks source link

Added ResourceConfiguration as parameter in NodeKind #672

Closed pernelkanic closed 10 months ago

pernelkanic commented 11 months ago

In the PageKind , Removed the PageReadOnlyTrx parameter and added a ResourceConfiguration parameter for passing the necessary data required for serialization and deserialization.

519

welcome[bot] commented 11 months ago

Thanks so much for opening this pull request and for helping to improve SirixDB 🚀

JohannesLichtenberger commented 11 months ago

It seems it doesn't compile anymore

JohannesLichtenberger commented 11 months ago

@pernelkanic can you fix it? Would be a great contribution 👍

pernelkanic commented 11 months ago

yeah sure!

JohannesLichtenberger commented 11 months ago

https://github.com/sirixdb/sirix/actions/runs/6595280725/job/17923052228?pr=672

I'm on my phone, but ghis is the log

JohannesLichtenberger commented 11 months ago

Still not compiling due to anothe issue!? Did it ever work for you? Running the tests locally?

JohannesLichtenberger commented 11 months ago

Can you fix the PR?