search

sirixdb / sirix

SirixDB is an an embeddable, bitemporal, append-only database system and event store, storing immutable lightweight snapshots. It keeps the full history of each resource. Every commit stores a space-efficient snapshot through structural sharing. It is log-structured and never overwrites data. SirixDB uses a novel page-level versioning approach.
https://sirix.io
BSD 3-Clause "New" or "Revised" License
1.11k stars 250 forks source link

Changed and added commands in docker files #717

Closed FayKounara closed 3 months ago

welcome[bot] commented 5 months ago

Thanks so much for opening this pull request and for helping to improve SirixDB 🚀

JohannesLichtenberger commented 5 months ago

Oh, what's this about? I thought it's Keycloak updated somehow

FayKounara commented 5 months ago

Hello! So these changes help the container keycloak to not start and exit immediately and when i altered these i was also able to build successfully the build.gradle from the folder sirix-rest-api.

JohannesLichtenberger commented 5 months ago

The thing is that the docker compose file in the root dir should build a new image from the sources (afterwards it's pushed to docker hub for use by the rest api bundle and for everyone).

FayKounara commented 5 months ago

Do you mean the sirixdb/sirix image? If you mean this image i build it with a command and then i was able to use it . Also both ports (the 8080 and 9443) are accessible and then i tried the python sdk api to see if it actually works.

FayKounara commented 5 months ago
Okay so i added this command and executed it again.From the reports that are produced i see this. Package Tests Failures Ignored Duration Success rate
io.sirix.rest 66 0 0 19.163s 100%

So can you please explain what is the problem with the sirix-rest-api because i see all the containers are running smoothly. Maybe i dont understand something. Thank you and sorry for the trouble.

JohannesLichtenberger commented 5 months ago

The docker compose file in sirix-rest-api uses the most recent version from docker hub, which is built before via the docker compose file in the root directory of the project. I'm still not really sure what's the problem you're facing. So, using the docker compose script in sirix-rest-api starts keycloak and stops it immediately?

FayKounara commented 5 months ago

Sorry for the confusion! I saw on the issue #711 this,The container doesn't start using the newest image,and also on the issue #707 that the tests fail. I think that these changes might help with these issues.

JohannesLichtenberger commented 5 months ago

Oh, #707 was fixed (the keycloak image only exists for quay.io). Idk what's wrong when updating Keycloak to the newest version, though. In any case, if your changes help, we could add the local build again, I guess, regarding the root docker compose file!? Otherwise it wouldn't be updated anymore (and pushed to docker hub).

FayKounara commented 5 months ago

If my changes prove effective, I will add the local build option in the root Docker Compose file again.Thank you and sorry for the confusion!

JohannesLichtenberger commented 5 months ago

So, you'll update the keycloak version and check?

FayKounara commented 5 months ago

Could you please clarify what specific steps you'd like me to take regarding the Keycloak update? Should i investigate the issue further or add the build . in the root file and check this?

JohannesLichtenberger commented 5 months ago

You'd have to update the Keycloak version as well (also add build . again, as it's mandatory to do a local image build)

JohannesLichtenberger commented 3 months ago

Can we close this?

FayKounara commented 3 months ago

Hello, yes!