search

sirjonasxx / G-Earth

Cross-platform Habbo packet manipulator
MIT License
91 stars 47 forks source link

Wrapped RC4 table checks in try catch block (#106) #127

Closed dorving closed 2 years ago

dorving commented 2 years ago

Might address #106, I am not sure what the code in Rc4Obtainer is doing exactly, but the exception thrown in the error reported at issue #106 will break out of the loop that tries out the possible tables. I am guessing maybe wrapping the flow of the loop inside a try catch block could resolve this? I am not sure how to handle the errors, since I do not know how RC4 works.

Also again, did some refactor work.

WiredSpast commented 2 years ago

I wouldn't add the DEBUG check for printing the stacktraces because we need those when helping people

dorving commented 2 years ago

I wouldn't add the DEBUG check for printing the stacktraces because we need those when helping people

Aight agreed, I wasn't sure if it was okay for it to fail like many items (i.e. in a trial and error fashion), and since the former stack trace was commented out, I figured I'd stick to that. But I'll add em back :)