sirjuddington / SLADE

It's a Doom editor
https://slade.mancubus.net
GNU General Public License v2.0
703 stars 112 forks source link

Homebrew-installed dumb conflicts with SLADE-provided dumb #1535

Open JustinWayland opened 1 year ago

JustinWayland commented 1 year ago

SLADE Version: (3.2.4) Operating System: (OSX)

Issue Details: If the user has previously installed dumb using Homebrew, SLADE will fail to compile due to missing definitions like LONG_LONG and MID, as well as conflicting function signatures.

Pedro-Beirao commented 9 months ago

I'm a bit lost trying to fix this 😅, currently I uninstall dumb from brew when compiling So, bump to see if anyone can do it

sirjuddington commented 9 months ago

There is a cmake option (in thirdparty/CMakeLists.txt) USE_SYSTEM_DUMB that I think should work

Pedro-Beirao commented 9 months ago

That option fails with "ld: failed to find 'libdumb'", unless I provide the full path to it (PkgConfig::DUMB does not work)

Ive messed so much with cmake and still cant fix this

Ritchie333 commented 1 month ago

This is still an active issue. As mentioned above, I had to uninstall dumb from homebrew before I could compile.

A long term fix would be to sync the project's version of the dumb source code with all package managers, if that's practical.