sirjuddington / SLADE

It's a Doom editor
https://slade.mancubus.net
GNU General Public License v2.0
686 stars 104 forks source link

ld: cannot find -lstdc++fs compile error #1633

Closed Eonfge closed 6 months ago

Eonfge commented 6 months ago

SLADE Version: 3.2.5 Operating System: Linux Flatpak

Issue Details:

/usr/lib/gcc/x86_64-unknown-linux-gnu/13.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lstdc++fs: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/slade.dir/build.make:4807: slade] Error 1
make[1]: *** [CMakeFiles/Makefile2:214: src/CMakeFiles/slade.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

https://github.com/flathub/net.mancubus.SLADE/pull/65

sirjuddington commented 6 months ago

Hmm what happens if you comment out the following: https://github.com/sirjuddington/SLADE/blob/7b3bf6759d4e3f2cf233dc8e5657e2312871137a/cmake/unix.cmake#L190

Eonfge commented 6 months ago

we have progressed!

FB: Running 'flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/slade --nofilesystem=host:reset --filesystem=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/slade-1 --bind-mount=/run/build/slade=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/slade-1 --build-dir=/run/build/slade --bind-mount=/run/ccache=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/ccache --unshare=network --env=SOURCE_DATE_EPOCH=1703154354 '--env=CFLAGS=-O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer ' '--env=CXXFLAGS=-O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer ' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed ' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=64 /srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/rofiles/rofiles-FjWbXR make install' on host
[  6%] Built target lunasvg
[  7%] Built target fmt
[ 31%] Built target external
[100%] Built target slade
Install the project...
-- Install configuration: "RelWithDebInfo"
-- Installing: /app/bin/slade
CMake Error at src/cmake_install.cmake:67 (file):
  file INSTALL cannot find "/run/build/slade/slade.pk3": No such file or
  directory.
Call Stack (most recent call first):
  cmake_install.cmake:47 (include)
make: *** [Makefile:100: install] Error 1
sirjuddington commented 6 months ago

Oh, you need to enable BUILD_PK3 when configuring cmake now

Eonfge commented 6 months ago

You sure, I tried both;

[1/2] Install the project...
-- Install configuration: "RelWithDebInfo"
-- Installing: /app/bin/slade
CMake Error at src/cmake_install.cmake:67 (file):
  file INSTALL cannot find "/run/build/slade/slade.pk3": No such file or
  directory.
Call Stack (most recent call first):
  cmake_install.cmake:47 (include)
FAILED: CMakeFiles/install.util 
cd /run/build/slade && /usr/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.
FB: host_command_exited_cb 3390135 256

https://github.com/flathub/net.mancubus.SLADE/pull/65/files

sirjuddington commented 6 months ago

Hmm not sure, is it building the pk3 at all? I did change where it puts it but that should be in Windows only.

Eonfge commented 6 months ago

It does make the file, by the looks of it:

https://buildbot.flathub.org/#/builders/26/builds/11025/steps/7/logs/stdio

sirjuddington commented 6 months ago

Oh, I think it might be to do with 6abd8c369bb5d7b84c0d2a063fdcfea481a08689 - I just added a new 3.2.5a tag, does it work using that?

charlesthobe commented 6 months ago

Should be closed with: https://github.com/sirjuddington/SLADE/pull/1637 I apologize for not tagging the issue in the PR so it would be closed automatically when merged.