sirjuddington / SLADE

It's a Doom editor
https://slade.mancubus.net
GNU General Public License v2.0
710 stars 109 forks source link

Regression? Ascii code 0x53 (^) not permitted in WAD entry names #1692

Open SSNTails opened 5 months ago

SSNTails commented 5 months ago

SLADE Version

3.2.6

OS

Windows

Editor

Resource editor

Steps to Reproduce and Observed Behavior

  1. Turn on allow lowercase in the preferences.
  2. Right click on an entry
  3. Choose 'Rename'
  4. Enter 'PLAY^2^8'
  5. See how it changes the entry name to 'PLAY\2\8'

This is required for old versions (legacy) of Sonic Robo Blast 2, as well as someone doing interesting things with older Doom engines (i.e., non-ZDoom based). With SLADE having support for all other characters as well as lowercase letters, it seems odd to skip over this sprite slot.

I'd issue a PR for this (line 317 lumpNameToFileName() appears to be where this lives in Misc.cpp), but I'm unsure about breaking other things.

Expected Behavior

Lump name should be PLAY^2^8

Screenshots

No screenshot is necessary.