edward-san
commented
9 years ago Yeah, now the left warnings are these:
/home/edward-san/zdoom/slade/src/SImageFormats.cpp:487:19: warning: taking the absolute value of unsigned type 'const uint8_t' (aka 'const unsigned char') has no effect [-Wabsolute-value]
width = ofs[5] + abs(ofs[3]);
^
/home/edward-san/zdoom/slade/src/SImageFormats.cpp:487:19: note: remove the call to 'abs' since unsigned values cannot be negative
width = ofs[5] + abs(ofs[3]);
^~~
1 warning generated.
/home/edward-san/zdoom/slade/src/Conversions.cpp:494:61: warning: '&&' within '||' [-Wlogical-op-parentheses]
if (mc.getSize() < 22 || mc.getSize() > 29 || (mc[12] != 1 && mc[12] != 5 || mc[mc.getSize()-1] != 0))
~~~~~~~~~~~~^~~~~~~~~~~~~~ ~~
/home/edward-san/zdoom/slade/src/Conversions.cpp:494:61: note: place parentheses around the '&&' expression to silence this warning
if (mc.getSize() < 22 || mc.getSize() > 29 || (mc[12] != 1 && mc[12] != 5 || mc[mc.getSize()-1] != 0))
^
( )
1 warning generated.
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:151:19: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant A, 2<B0> Observer", "Illuminant A, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:151:49: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant A, 2<B0> Observer", "Illuminant A, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:152:19: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant C, 2<B0> Observer", "Illuminant C, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:152:49: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant C, 2<B0> Observer", "Illuminant C, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:153:21: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D50, 2<B0> Observer", "Illuminant D50, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:153:53: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D50, 2<B0> Observer", "Illuminant D50, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:154:21: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D60, 2<B0> Observer", "Illuminant D60, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:154:53: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D60, 2<B0> Observer", "Illuminant D60, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:155:21: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D65, 2<B0> Observer", "Illuminant D65, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:155:53: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D65, 2<B0> Observer", "Illuminant D65, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:156:21: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D75, 2<B0> Observer", "Illuminant D75, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:156:53: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant D75, 2<B0> Observer", "Illuminant D75, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:157:20: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant F2, 2<B0> Observer", "Illuminant F2, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:157:51: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant F2, 2<B0> Observer", "Illuminant F2, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:158:21: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant TL4, 2<B0> Observer", "Illuminant TL4, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:158:53: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant TL4, 2<B0> Observer", "Illuminant TL4, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:159:24: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant UL3000, 2<B0> Observer", "Illuminant UL3000, 10<B0> Observer",
^~~~
/home/edward-san/zdoom/slade/src/Dialogs/Preferences/ColorimetryPrefsPanel.cpp:159:59: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
"Illuminant UL3000, 2<B0> Observer", "Illuminant UL3000, 10<B0> Observer",
^~~~though there are some other warnings which got out with -Wall and -Wextra I'd like to show ASAP.
sirjuddington
Hi. I got these warnings when I compile slade:
1)
Was that call needed because the value should be in the
[0,127]range? Sinceofsis unsigned char, its value is in the[0,255]range, and when converted toint, the range is not touched, soabswill return in the[0, 255]range.2)
The function
abshas parameterintand returnsint, so the argument in these calls will be converted tointand hence lose the decimals, therefore the returned value can't have the lost decimals. You can usestd::absorfabs.3)
The macro
LOG_MESSAGEcontains anifand noelse, hence theelsehere is referred to the conditionGlobal::log_verbosity >= level, thereforefiles_written.push_back(path);would be executed when the condition!entries[a]->exportFile(path)is true... very dangerous.4)
It's not clear which logic order should have these mixed conditions, so the parentheses are needed, in order to clarify if
||must be checked before or after&&(for example, I'm sure thatif (key == "F" || key == "f" && side1)can be written asif ((key == "F" || key == "f") && side1), becausekeymust be case insensitive).5)
Since the file in question is encoded in ISO-8859,
°is not a valid character inside a string, hence when I open the menu Graphics->Colorimetry, the CIE Lab Tristimulus option has invisible string values. Replacing any instance of°with\xc2\xb0in these strings and enclosing them inwxString::FromUTF8()fixes the problem for me.6)
If you assign something and this must be
NULLchecked, enclose the assignment in another parenthesis.7)
No idea why this was written like that. Maybe it's really unused and hence it needs
(void)?8)
Apparently these functions are similar to some virtual functions in some base classes for their name, but it's not clear if these were intended to override them or not, because of the mismatching number of parameters.
9)
This can be fixed by swapping
nameandvaluemember definitions inside thearg_val_tclass.10)
That sounds like a big mistake, because a
charcan be negative in suitable platforms, hence there's a potential read of garbage data before the array region.