Add Support For Google plus JS SDK login

sirkitree / angular-directive.g-signin

:triangular_ruler: AngularJS Directive for Google Plus Sign-in Button

http://jeradbitner.com/angular-directive.g-signin/

148 stars 84 forks source link

Add Support For Google plus JS SDK login #10

Closed djds4rce closed 9 years ago

djds4rce commented 10 years ago

Proposal To move the Defaults Array to a Factory so it can be configured in the angular 'config' block and add support Google Plus JS SDK login. Why? It would nice if we could Style the google login button to our requirement, but the current implementation of directives doesn't let you do that. Also It would be nice to give a flexibility of implementation.

Thoughts?

sirkitree commented 10 years ago

Sounds good. I think I even had a comment in there at some point to figure out how to make those variables configurable/overridable.

djds4rce commented 10 years ago

I Will Start Working On it then and come up with a PR soon Enough.