search

sirkitree / angular-directive.g-signin

:triangular_ruler: AngularJS Directive for Google Plus Sign-in Button
http://jeradbitner.com/angular-directive.g-signin/
148 stars 84 forks source link

Forked repo registered in Bower #11

Closed doingweb closed 10 years ago

doingweb commented 10 years ago

A bower update earlier this evening broke my build. After a little investigation, I noticed that @andresesfm's fork (which is a number of commits behind) is registered in the Bower registry instead of this one. I feel like this repo should be the one registered for this package in Bower, given that it is the main line of the package.

Thoughts? I'd like to hear @andresesfm's position on this.

andresesfm commented 10 years ago

Hello @doingweb, I originally created the fork to add it to bower. However I ended up doing some changes myself. Having said that, Bower is an open repository. You could do the following:

1) Fork @sirkitree 's repository, 2) Add bower files 3) Submit a pull request 4) Wait for it to be accepted 5) Add a new entry to bower registry pointing to @sirkitree 's url. Instructions here: http://bower.io/

Regards, Andres

sirkitree commented 10 years ago

@andresesfm why didn't you just send me a pull request? I would have been okay adding to the bower registry. Seems like adding a fork to a registry might not be a very good practice.

andresesfm commented 10 years ago

@sirkitree As I mentioned, I made some changes myself, it is now a true fork of your work (giving credit to your work of course).

I offered my version to people using the registry but there's nothing that says that yours can't be there at the same time. I included the instructions on how to do it if it is something you are interested in doing it yourself.

This is good, this is the true nature of open source: we can all contribute.

sirkitree commented 10 years ago

@andresesfm sure, no problem forking. I'm just curious as to why your changes wouldn't have been proposed back to this repo is all. Are they not good candidates for the original?

doingweb commented 10 years ago

I don't have a problem with you having your fork in the Bower registry, @andresesfm. And I certainly have no problem with your fork having its own goals, divergent from the parent project. It's just that it's registered under the same name as the parent repo, and that is not at all what I expect.

May I suggest that you register your fork as angular-directive.g-signin.andresesfm, then unregister angular-directive.g-signin for @sirkitree to claim? I think this convention would convey all the right information to a user of Bower, especially if we make good use of the description field.

doingweb commented 10 years ago

Excellent! The name was released earlier today, and I just registered it to point to this repo. Thanks @andresesfm!