search

sirkitree / angular-directive.g-signin

:triangular_ruler: AngularJS Directive for Google Plus Sign-in Button
http://jeradbitner.com/angular-directive.g-signin/
148 stars 84 forks source link

problem with data- #18

Closed herrerodani closed 10 years ago

herrerodani commented 10 years ago

Angularjs removes data- from attributtes, so !attrs.hasOwnProperty('data-' + propName) is always true and the default values cannot be overwriten.

Than you.

herrerodani commented 10 years ago

Related issue https://github.com/angular/angular.js/issues/4478

frankbille commented 10 years ago

I was also bitten by this, so have created a pull request that should fix the issue.