Closed phw closed 9 years ago
Excellent, thank you very much!
I just noticed a different but related issue: You cannot use any attribute that is not defined in the defaults, e.g. height.
I see three ways this could be solved:
I tend toward 2. Any thoughts?
I think we should just allow everything.
This patch will probably overwrite the default values with explicitly provided valuies. Without this patch overwriting any value, as e.g.
width
in the example below, won't work:The existing code does update the attributes with the default values, but the attributes are actually never used since the defaults are passed directly to
gapi.signin.render
. This patch reverses this and now the defaults get overwritten with explicitly provided attributes.