search

sirkitree / angular-directive.g-signin

:triangular_ruler: AngularJS Directive for Google Plus Sign-in Button
http://jeradbitner.com/angular-directive.g-signin/
148 stars 84 forks source link

Better manage pass-through attributes #5

Closed dbitting closed 11 years ago

dbitting commented 11 years ago

Hi. Forgive me if this is all wrong. I'm new both to git and to Angular (and its supporting technologies). This old dog is trying to learn some new tricks. :)

This set of changes allows for attributes on the g+signin element to be passed through to the G+ API. It tries to be a little intelligent about handling defaults by setting the values that you had in the previous version of this directive, but only if the user hasn't explicitly set a value.

Additionally, I changed the name of the component slightly to make bower happy and revved the component version to 0.0.2.

Please review and incorporate as desired/appropriate.

Thanks, --Doug

sirkitree commented 11 years ago

Thank you! This basically closes out #2 I think :)

sirkitree commented 11 years ago

I've also made you a collaborator - hazard of sending a pull request ya know :wink: